Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Add acceptance coverage verifying that unset or false expunge leaves the destroyed volume available for manual cleanup.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Updates cloudstack_disk to use CloudStack’s destroy API with optional volume expunging, consistent with instance behavior.
Changes:
- Adds the
expungeargument, defaulting tofalse. - Replaces
DeleteVolumewith conditional destruction and expunging. - Updates documentation and acceptance configurations.
File summaries
| File | Summary |
|---|---|
website/docs/r/disk.html.markdown |
Documents the expunge argument. |
cloudstack/resource_cloudstack_disk.go |
Implements configurable volume destruction. |
cloudstack/resource_cloudstack_disk_test.go |
Updates tests; a nit requests coverage for the default expunge = false behavior. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapting the disk resource according to the instance standard as it also uses destroy. This destroys the disk but (optionally) leaves it unexpunged for manual cleanup or satefy measures.
Acceptance tests pass, also tested on an actual setup.